Add lint job in CI

[m-Peter]

Description

Run golangci-lint in CI workflow.

---

For contributor use:

• Targeted PR against master branch
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the standards mentioned here.
• Updated relevant documentation
• Re-reviewed Files changed in the Github PR explorer
• Added appropriate labels

Summary by CodeRabbit

• Refactor

  • Moved a method within the codebase for better organization.
  • Renamed a function for clarity.

• Bug Fixes

  • Removed a redundant variable declaration.
  • Adjusted logic in a method to fix a parameter issue.
  • Improved error handling in a specific function.

• Documentation

  • Updated a test function to handle binary data errors.
  • Removed an unused function from the test suite.

• Tests

  • Modified a test function to improve transaction submission handling.

[coderabbitai]

Walkthrough

The changes encompass method refactoring, error handling improvements, and logic adjustments across multiple files to enhance functionality and maintainability.

Changes

File Path	Change Summary
api/models.go, api/pull_test.go	- Moved prepare method to models.go.
	- Removed errFilterNotFound declaration.
	- Added new error variables errExceedMaxTopics and errExceedMaxAddresses.
--------------------------------------------------	---------------------------------------------------------------------------
api/stream.go	- Modified NewPendingTransactions method to handle fullTx parameter logic changes.
--------------------------------------------------	---------------------------------------------------------------------------
bootstrap/create-multi-key-account.go	- Added error handling logic within CreateMultiKeyAccount function.
--------------------------------------------------	---------------------------------------------------------------------------
cmd/main/setup-multi-key-account.go	- Renamed setupKey function to SetupKey.
--------------------------------------------------	---------------------------------------------------------------------------
models/transaction_test.go	- Updated createTestEvent function to handle errors during unmarshaling binary data.
--------------------------------------------------	---------------------------------------------------------------------------
tests/helpers.go	- Removed getFilterChangesLogs function.
--------------------------------------------------	---------------------------------------------------------------------------
tests/integration_test.go	- Modified Test_ConcurrentTransactionSubmission to change nonce initialization and increment logic.

🐇💬
In the code's garden, changes bloom anew,
Methods refactored, errors bid adieu.
Logic shifts and enhancements take flight,
Codebase dances to a tune so right.
With each update, the code finds its way,
Evolving gracefully day by day. 🌱
🥕

---

Recent Review Details

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 8e0e494 and 3acb315.

Files selected for processing (9)

• .github/workflows/ci.yml (1 hunks)
• api/models.go (1 hunks)
• api/pull_test.go (1 hunks)
• api/stream.go (1 hunks)
• bootstrap/create-multi-key-account.go (2 hunks)
• cmd/main/setup-multi-key-account.go (2 hunks)
• models/transaction_test.go (1 hunks)
• tests/helpers.go (2 hunks)
• tests/integration_test.go (2 hunks)

Files skipped from review as they are similar to previous changes (9)

• .github/workflows/ci.yml
• api/models.go
• api/pull_test.go
• api/stream.go
• bootstrap/create-multi-key-account.go
• cmd/main/setup-multi-key-account.go
• models/transaction_test.go
• tests/helpers.go
• tests/integration_test.go

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.