Update bootstrap logic and README instructions to work with a local Emulator #138
Conversation
m-Peter
force-pushed
the
update-bootstrap-for-emulator
branch
from
863a1f5 to
a916727
Compare
| @@ -14,6 +14,13 @@ import ( | |||
| "github.com/onflow/flow-go/utils/io" | |||
| ) | |||
|
|
|||
| // Default InitCadenceHeight for initializing the database on a local emulator. | |||
| const EmulatorInitCadenceHeight = uint64(0) | |||
There was a problem hiding this comment.
but this will cause the same issue with subscribing to events on the emulator right? the value 0 will be sent as the latest value to event subscription which will mean just get me the latest height. But if the evm-gateway misses some events on emulator and is then started it will also miss processing those events. I'm not sure how this is different?
There was a problem hiding this comment.
Currently, it is not possible to use the Emulator locally. Starting the gateway fails with:
panic: failed to start event ingestion: failed to get provided cadence height: client: rpc error: code = NotFound desc = could not find block at height 1That's because upon starting the Emulator, there is no block with height 1. On a live network, such block will most likely exist.
There was a problem hiding this comment.
I understand that, but the problem I described still exists. So if the emulator is started and then later evm-gateway the evm-gateway will miss all the events that happened before. Neither is great tbh. So I think the ultimate solution here would be to change the flow-go height 0 treated as special value. Until then we can probably use this solution, but add a todo with the issue linked saying that once this is merged we should remove all of this: onflow/flow-go#5481
There was a problem hiding this comment.
Sounds good. Added in 75a13ca
There was a problem hiding this comment.
Maybe also add in readme an explanation that evm-gateway will be starting from latest emulator block, so if emulator is run before and transactions happen evm-gateway won't fetch those historically. You can also add a note that this will be improved soon.
There was a problem hiding this comment.
Good idea, let me do that quickly.
m-Peter
force-pushed
the
update-bootstrap-for-emulator
branch
from
75a13ca to
66756ea
Compare
m-Peter
force-pushed
the
update-bootstrap-for-emulator
branch
from
66756ea to
95350f4
Compare
Description
For contributor use:
masterbranchFiles changedin the Github PR explorer