General improvements and tech-debt #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
March 1, 2024 14:04
added 3 commits
March 1, 2024 16:32
m-Peter
reviewed
Mar 1, 2024
| flag.StringVar(&coinbase, "coinbase", "", "coinbase address to use for fee collection") | ||
| flag.StringVar(&gas, "gas-price", "1", "static gas price used for EVM transactions") | ||
| flag.StringVar(&flowChainID, "flow-network-id", "flow-emulator", "Flow network ID (flow-emulator, flow-previewnet)") | ||
| flag.StringVar(&coinbase, "coinbase", "", "Coinbase address to use for fee collection") |
There was a problem hiding this comment.
A bit out of context of this PR, but it occurred to me that we might better fetch this from the COA resource that resides in the coa-address. We can do this either through a script on startup and memoize the value.
There was a problem hiding this comment.
ohh you are right, can you open an issue for this.
m-Peter
reviewed
Mar 1, 2024
m-Peter
reviewed
Mar 1, 2024
| index int | ||
| seqNum uint64 | ||
| ) | ||
| // execute concurrently so we can speed up all the information we need for tx |
m-Peter
reviewed
Mar 1, 2024
m-Peter
reviewed
Mar 1, 2024
| } | ||
| // make the list of all contracts we should replace address for | ||
| sc := systemcontracts.SystemContractsForChain(e.chainID) | ||
| contracts := []systemcontracts.SystemContract{sc.EVMContract, sc.FungibleToken, sc.FlowToken} |
Co-authored-by: Ardit Marku <[email protected]>
m-Peter
reviewed
Mar 1, 2024
services/requester/requester.go
Outdated
| return flow.EmptyID, fmt.Errorf("failed to sign envelope: %w", err) | ||
| } | ||
|
|
||
| err = e.client.SendTransaction(ctx, *flowTx) | ||
| if err != nil { | ||
| err := e.client.SendTransaction(ctx, *flowTx) |
There was a problem hiding this comment.
Suggested change
| err := e.client.SendTransaction(ctx, *flowTx) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General improvements to the code, addressing some todos, removing non-relevant todos, concurrently get data from network, improve balance conversions...