better error handling

onflow · Feb 21, 2024 · ba0a059 · ba0a059
1 parent 9d5b7dc
commit ba0a059
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/api/api.go b/api/api.go
@@ -259,7 +259,7 @@ func (b *BlockChainAPI) GetTransactionReceipt(
 			return nil, errs.ErrInternal
 		}
 
-		return nil, err
+		return nil, fmt.Errorf("failed to get transaction receipt: %w", err)
 	}
 
 	return rcp, nil

diff --git a/storage/pebble/receipts.go b/storage/pebble/receipts.go
@@ -59,10 +59,15 @@ func (r *Receipts) GetByTransactionID(ID common.Hash) (*gethTypes.Receipt, error
 
 	height, err := r.store.get(receiptTxIDToHeightKey, ID.Bytes())
 	if err != nil {
-		return nil, err
+		return nil, fmt.Errorf("failed to get receipt by tx ID: %w", err)
+	}
+
+	rcp, err := r.getByBlockHeight(height)
+	if err != nil {
+		return nil, fmt.Errorf("failed to get receipt by height: %w", err)
 	}
 
-	return r.getByBlockHeight(height)
+	return rcp, nil
 }
 
 func (r *Receipts) GetByBlockHeight(height *big.Int) (*gethTypes.Receipt, error) {