Add NFT Bridging Cadence tests #24
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -487,6 +487,16 @@ fun bridgeNFTToEVM(signer: Test.TestAccount, contractAddr: Address, contractName | |
| signer | ||
| ) | ||
| Test.expect(bridgeResult, Test.beSucceeded()) | ||
|
|
||
| var events = Test.eventsOfType(Type<NonFungibleToken.Withdrawn>()) | ||
| let withdrawnEvent = events[events.length - 1] as! NonFungibleToken.Withdrawn | ||
| Test.assertEqual(nftID, withdrawnEvent.id) | ||
| Test.assertEqual(signer.address, withdrawnEvent.from!) | ||
|
|
||
| events = Test.eventsOfType(Type<NonFungibleToken.Deposited>()) | ||
| let depositedEvent = events[events.length - 1] as! NonFungibleToken.Deposited | ||
| Test.assertEqual(nftID, depositedEvent.id) | ||
| Test.assertEqual(bridgeAccount.address, depositedEvent.to!) | ||
| } | ||
|
|
||
| access(all) | ||
|
|
@@ -497,5 +507,13 @@ fun bridgeNFTFromEVM(signer: Test.TestAccount, contractAddr: Address, contractNa | |
| signer | ||
| ) | ||
| Test.expect(bridgeResult, Test.beSucceeded()) | ||
|
|
||
| var events = Test.eventsOfType(Type<NonFungibleToken.Withdrawn>()) | ||
| let withdrawnEvent = events[events.length - 1] as! NonFungibleToken.Withdrawn | ||
| Test.assertEqual(bridgeAccount.address, withdrawnEvent.from!) | ||
|
There was a problem hiding this comment. I would like to add some assertions to check the There was a problem hiding this comment. I think the best way to do this would be to look for the subsequent |
||
|
|
||
| events = Test.eventsOfType(Type<NonFungibleToken.Deposited>()) | ||
| let depositedEvent = events[events.length - 1] as! NonFungibleToken.Deposited | ||
| Test.assertEqual(signer.address, depositedEvent.to!) | ||
| } | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a few more lines after this one and for the next test to verify this worked? Could be as simple as using the get ids to make sure the id still exists here in the account on the evm side, and similar for the next test. Also an event emitted check would be good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are actually helper functions, used in test cases. The actual tests do contain assertions for checking the IDs etc.
I have added some assertions about checking emitted events: f45ad59