Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug from flow deps add command missing Flags field #1539

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Apr 25, 2024

Description

There's a bug in dependency manager command flags causing an error to always be shown at startup. This is a quick patch to work around it.

Screenshot 2024-04-24 at 6 07 00 PM

It's displaying this "specification must be a struct pointer" message, probably coming from some reflection happening inside sconfig where it doesn't like missing flags.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@jribbink jribbink added the Improvement Technical work without new features, refactoring, improving tests label Apr 25, 2024
@jribbink jribbink changed the title Fix bug with dependency manager missing flags error Fix bug from flow deps add command missing flags field Apr 25, 2024
@jribbink jribbink changed the title Fix bug from flow deps add command missing flags field Fix bug from flow deps add command missing Flags field Apr 25, 2024
@jribbink jribbink merged commit 952a96b into master Apr 25, 2024
10 checks passed
@jribbink jribbink deleted the jribbink/flags-error-patch branch April 25, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Technical work without new features, refactoring, improving tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants