Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document resource identifiers #394

Merged
merged 4 commits into from
Oct 9, 2020
Merged

Document resource identifiers #394

merged 4 commits into from
Oct 9, 2020

Conversation

turbolent
Copy link
Member

Closes #389

@turbolent turbolent added the Documentation Improvements or additions to documentation label Sep 30, 2020
@turbolent turbolent self-assigned this Sep 30, 2020
@turbolent turbolent requested a review from psiemens September 30, 2020 22:43
jordanschalm
jordanschalm approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@jordanschalm jordanschalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added one phrasing suggestion

docs/language/composite-types.mdx Outdated Show resolved Hide resolved
turbolent and others added 2 commits October 5, 2020 17:45
@turbolent
fix typo
7607354
@turbolent @jordanschalm
improve phrase
9b809fc 
Co-authored-by: Jordan Schalm <[email protected]>
@turbolent
Copy link
Member Author

Thanks for the review @jordanschalm!

@turbolent
Copy link
Member Author

@joshuahannan could you please have a look?

joshuahannan
joshuahannan approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@joshuahannan joshuahannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain how identifiers are assigned and give an example?

@turbolent
Copy link
Member Author

That's out-of-scope for Cadence, i.e. done by the host environment embedding Cadence.
I'll mention that, and also recommend not relying on or assuming any particular behaviour.

@turbolent turbolent merged commit 3038648 into master Oct 9, 2020
@turbolent turbolent deleted the bastian/389-document-resource-identifiers branch October 9, 2020 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuahannan joshuahannan joshuahannan approved these changes

@jordanschalm jordanschalm jordanschalm approved these changes

@zhangchiqing zhangchiqing Awaiting requested review from zhangchiqing

@psiemens psiemens Awaiting requested review from psiemens

Assignees

@turbolent turbolent

Labels
Documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document resource UUIDs
3 participants
@turbolent @joshuahannan @jordanschalm