Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync compiler feature branch #3783

Closed
wants to merge 59 commits into from
Closed

Sync compiler feature branch #3783

wants to merge 59 commits into from

Conversation

turbolent
Copy link
Member

Work towards #3742

Description

Update the compiler feature branch by merging master into it.

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

turbolent and others added 30 commits November 26, 2024 14:03
@turbolent
decouple Value.StaticType from interpreter
5be8fd1
Add .syntax file for describing the Cadence programming language scan…
6f80ccf 
…ner and parser.
Add syntax notation document.
b1ba6d5
@turbolent
decouple Value.Equal from Interpreter, remove unnecessary parameters
ba888b5
@turbolent
decouple Value comparison functions from Interpreter
15f3cd0
@turbolent
decouple arithmetic functions on number values from Interpreter
d8af8f2
@turbolent
decouple InclusiveRange iterator from interpreter
53d2c2e
@turbolent
improve naming
fbd8634
@turbolent
decouple iterator iteration from Interpreter
bb0c5fa
@turbolent
improve value iterators, delete unnecessary code
a087ade
@turbolent
simplify ephemeral reference tracking
653bc7a
@turbolent
Merge branch 'master' into bastian/decouple-values-from-interpreter
181f62b
@turbolent
Merge branch 'bastian/decouple-values-from-interpreter' into bastian/…
c155736 
…decouple-values-from-interpreter-2
@turbolent
format
1c46ead
@turbolent
make command execution fail on exit codes
876760b
@turbolent
update to latest actions/upload-artifact
16a7683
@turbolent
Merge pull request #3750 from onflow/bastian/fix-ci-2
bad88fc 
Fix backward compatibility job
@turbolent
decouple IntegerValue from interpreter
357bcb7
@turbolent
decouple MustConvertStaticToSemaType and MustSemaTypeOfValue from int…
657d8f5 
…erpreter
@turbolent
decouple DictionaryValue.SemaType from interpreter
dfc9022
@turbolent
decouple Value.IsResourceKinded from interpreter
72c0a5d
@turbolent
decouple ResourceKindedValue.isInvalidatedResource from interpreter
226b8a7
@turbolent
decouple checkInvalidatedResourceOrResourceReference from interpreter
74a29bb
update Cadence.syntax with PR comments and recommendations
30e4b67
@j1010001
Update README.md
febe61b
@turbolent
Merge pull request #3752 from onflow/jan/add-link-to-cadence-wg
37c36b4 
Update readme to add reference to Cadence working group
remove U+0000 for whitespace and add comment for baseType of typeRest…
4b2d352 
…rictions
@turbolent
remove unused dependencies, as they now cause errors
1f8eee4 
e.g. "Missing go.mod entry for dep onflow/flowkit/v2"
@turbolent
Merge pull request #3753 from onflow/bastian/update-update-tool-config-3
ea73985 
Update config of update tool
@jsproz
Merge pull request #3707 from onflow/sprowes/syntax
0df2af0 
Machine readable syntax specification
SupunS and others added 23 commits February 18, 2025 09:02
@SupunS @turbolent
Add a second level validation
6f24819
@turbolent
handle invalidated reference when exporting
b3501bb
@turbolent
handle export of nil
8fb1c5b
@turbolent
put export fixes behind versioned feature flag
86c4686
@turbolent
fix scope for function expressions and inner functions by capturing a…
ab53cbd 
… clone
@turbolent
test invalid function type subtyping: grant of additional entitlement…
1bbe7e2 
…s for reference
@turbolent
add mutation of captured variable after capture
6189dd2
@turbolent
instead of cloning, push a new activation after function expressions …
fbba47b 
…and inner functions
@turbolent
put closure scoping fix behind versioned feature flag
1a9cf56
@SupunS @turbolent
Add a feature flag to the fix for function conditions
7ac903a
@turbolent
make interface condition deduplication feature flag version-based, ad…
1ee093a 
…d runtime tests
@turbolent
remove feature flags, enable all new fixes
95214b0
@turbolent
Merge pull request #3775 from onflow/bastian/v1.3-port-internal-fixes
266c157 
[v1.3] Port internal fixes
@turbolent
v1.3.2
ecc5f63
@turbolent
Merge pull request #3777 from onflow/release/v1.3.2
03b3b22 
Merge `release/v1.3.2` to `v1.3`
@turbolent
Merge pull request #3776 from onflow/v1.3
f2feb7b 
Port internal fixes to master
@turbolent
instead of pushing an additional activation, capture a clone of the c…
add4b32 
…urrent activation

pushing an additional activation would also have to get popped at the end
of the function call to ensure the activation stack stays balanced
@turbolent
update comments
f73f4d9
@turbolent
add tests
c4d09e5
@turbolent
Merge pull request #3778 from onflow/bastian/v1.3-port-internal-fix-2
ef26e0d 
[v1.3] Port internal fix
@turbolent
fix and improve compat suite
6fb1f0d
@turbolent
add Dapper NFL smart contracts
58591a0
@turbolent
Merge pull request #3780 from onflow/bastian/improve-compat-suite
931f404 
Fix and improve compat suite
@turbolent turbolent requested a review from jsproz February 19, 2025 23:14
@turbolent turbolent self-assigned this Feb 19, 2025
@turbolent turbolent requested a review from SupunS as a code owner February 19, 2025 23:14
@github-actions GitHub Actions
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:feature/compiler commit f694f6e
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@turbolent
Copy link
Member Author

Replaced by #3785

@turbolent turbolent closed this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsproz jsproz Awaiting requested review from jsproz

@SupunS SupunS Awaiting requested review from SupunS SupunS is a code owner

Assignees

@turbolent turbolent

Labels
Chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@turbolent @j1010001 @jsproz @SupunS