Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable CodeQL action in private repo and update to latest version #3765

Closed

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Feb 12, 2025

Description

Port of https://github.com/onflow/cadence-internal/pull/301

The CodeQL action does not currently work in the private repo, as it requires the "Advanced Security" feature of GitHub to be enabled (it is enabled for all public repos for free).

Also, update to the latest version of the action.

Please also review the original PR.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent requested a review from jsproz February 12, 2025 21:38
@turbolent turbolent self-assigned this Feb 12, 2025
@turbolent turbolent requested a review from SupunS as a code owner February 12, 2025 21:38
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit f9aabc2
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@SupunS
Copy link
Member

SupunS commented Feb 12, 2025

Seems like CodeQL is not running for public repo as well 🤔

@turbolent turbolent closed this Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants