Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple interpreter values from interpreter – Part 3 #3751

Merged
merged 6 commits into from
Feb 13, 2025
Merged

Decouple interpreter values from interpreter – Part 3 #3751

merged 6 commits into from
Feb 13, 2025

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Jan 31, 2025 •
edited
Loading

Work towards #3693

Description

Continue decoupling the values from the interpreter / cleaning up unnecessary code in the interpreter values.

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels
    …decouple-values-from-interpreter-2

@turbolent turbolent requested a review from jsproz January 31, 2025 00:29
@turbolent turbolent self-assigned this Jan 31, 2025
@turbolent turbolent requested a review from SupunS as a code owner January 31, 2025 00:29
Base automatically changed from bastian/decouple-values-from-interpreter-2 to master February 13, 2025 02:03
@turbolent turbolent closed this Feb 13, 2025
@turbolent turbolent reopened this Feb 13, 2025
@github-actions GitHub Actions
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit b72a603
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@turbolent turbolent added the Go API Breaking Change Breaks programs which use the Cadence repo as a Go dependency label Feb 13, 2025
@turbolent turbolent merged commit 14086f2 into master Feb 13, 2025
10 of 12 checks passed
@turbolent turbolent deleted the bastian/decouple-values-from-interpreter-3 branch February 13, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsproz jsproz jsproz approved these changes

@SupunS SupunS SupunS approved these changes

Assignees

@turbolent turbolent

Labels
Go API Breaking Change Breaks programs which use the Cadence repo as a Go dependency Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turbolent @jsproz @SupunS