Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Go patterns used in the codebase #3649

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

turbolent
Copy link
Member

Description

Explain some of the Go code patterns that are used in the Cadence codebase.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent requested a review from jsproz October 28, 2024 22:11
@turbolent turbolent requested a review from SupunS as a code owner October 28, 2024 22:11
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 0b92557
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@turbolent turbolent self-assigned this Oct 28, 2024
@turbolent turbolent added the Documentation Improvements or additions to documentation label Oct 28, 2024
@turbolent turbolent merged commit 1c029f3 into master Oct 29, 2024
8 of 12 checks passed
@turbolent turbolent deleted the bastian/document-go-patterns branch October 29, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants