Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexport fields to prevent access by index #3290

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Unexport fields to prevent access by index #3290

merged 2 commits into from
Apr 30, 2024

Conversation

turbolent
Copy link
Member

Closes #2952

Description

Unexport cadence composite value's fields field, to prevent access by index, and require access by field name instead.

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent added Improvement Go API Breaking Change Breaks programs which use the Cadence repo as a Go dependency labels Apr 26, 2024
@turbolent turbolent self-assigned this Apr 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 26, 2024 •
edited
Loading

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 89f8a41
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

old.txtnew.txt
time/opdelta
DecodeBatchEventsCCF-4541ms ± 0%232ms ± 0%~(p=1.000 n=1+1)
DecodeBatchEventsJSON-4677ms ± 0%667ms ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-45.08µs ± 0%5.06µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowFees.TokensWithdrawn-43.58µs ± 0%3.72µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-45.43µs ± 0%5.37µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-45.60µs ± 0%5.65µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-43.89µs ± 0%4.13µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.RewardsPaid-44.54µs ± 0%4.50µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensDeposited-44.45µs ± 0%4.69µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-44.49µs ± 0%4.42µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensMinted-43.74µs ± 0%3.87µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensWithdrawn-44.54µs ± 0%4.69µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowFees.FeesDeducted-415.6µs ± 0%16.2µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowFees.TokensWithdrawn-410.5µs ± 0%10.7µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-414.6µs ± 0%15.2µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-418.2µs ± 0%19.0µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-410.6µs ± 0%10.4µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.RewardsPaid-413.4µs ± 0%12.3µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensDeposited-413.7µs ± 0%13.5µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-412.7µs ± 0%11.9µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensMinted-410.7µs ± 0%10.3µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensWithdrawn-413.6µs ± 0%13.5µs ± 0%~(p=1.000 n=1+1)
EncodeBatchEventsCCF-4143ms ± 0%150ms ± 0%~(p=1.000 n=1+1)
EncodeBatchEventsJSON-4166ms ± 0%174ms ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-43.05µs ± 0%3.29µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowFees.TokensWithdrawn-42.39µs ± 0%2.43µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-43.53µs ± 0%3.33µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-43.31µs ± 0%3.70µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-42.40µs ± 0%2.52µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.RewardsPaid-43.28µs ± 0%3.28µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensDeposited-43.09µs ± 0%3.20µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-42.90µs ± 0%3.06µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensMinted-42.41µs ± 0%2.46µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensWithdrawn-43.15µs ± 0%3.12µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowFees.FeesDeducted-43.90µs ± 0%4.04µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowFees.TokensWithdrawn-41.97µs ± 0%2.24µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-43.49µs ± 0%3.65µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-44.48µs ± 0%4.72µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-42.13µs ± 0%2.31µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.RewardsPaid-42.98µs ± 0%3.21µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensDeposited-43.48µs ± 0%3.79µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-42.55µs ± 0%2.87µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensMinted-41.96µs ± 0%2.33µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensWithdrawn-43.46µs ± 0%3.72µs ± 0%~(p=1.000 n=1+1)
ExportType/composite_type-4323ns ± 0%318ns ± 0%~(p=1.000 n=1+1)
ExportType/simple_type-470.4ns ± 0%70.3ns ± 0%~(p=1.000 n=1+1)
InterpretRecursionFib-44.05ms ± 0%4.10ms ± 0%~(p=1.000 n=1+1)
NewInterpreter/new_interpreter-41.10µs ± 0%1.12µs ± 0%~(p=1.000 n=1+1)
NewInterpreter/new_sub-interpreter-4508ns ± 0%503ns ± 0%~(p=1.000 n=1+1)
ParseArray-47.26ms ± 1%7.26ms ± 1%~(p=1.000 n=2+2)
ParseDeploy/byte_array-410.7ms ± 1%11.3ms ± 2%~(p=0.333 n=2+2)
ParseDeploy/decode_hex-41.08ms ± 2%1.08ms ± 1%~(p=1.000 n=2+2)
ParseFungibleToken/With_memory_metering-4179µs ± 3%181µs ± 4%~(p=1.000 n=2+2)
ParseFungibleToken/Without_memory_metering-4145µs ± 3%144µs ± 2%~(p=0.667 n=2+2)
ParseInfix-46.41µs ± 4%6.21µs ± 1%~(p=0.667 n=2+2)
QualifiedIdentifierCreation/One_level-42.48ns ± 0%2.48ns ± 0%~(p=1.000 n=1+1)
QualifiedIdentifierCreation/Three_levels-491.8ns ± 0%92.0ns ± 0%~(p=1.000 n=1+1)
RuntimeScriptNoop-48.75µs ± 0%9.05µs ± 0%~(p=1.000 n=1+1)
SuperTypeInference/arrays-4256ns ± 0%279ns ± 0%~(p=1.000 n=1+1)
SuperTypeInference/composites-499.2ns ± 0%99.0ns ± 0%~(p=1.000 n=1+1)
SuperTypeInference/integers-4316ns ± 0%315ns ± 0%~(p=1.000 n=1+1)
ValueIsSubtypeOfSemaType-478.4ns ± 0%79.2ns ± 0%~(p=1.000 n=1+1)
 
alloc/opdelta
DecodeBatchEventsCCF-466.5MB ± 0%66.5MB ± 0%~(p=1.000 n=1+1)
DecodeBatchEventsJSON-4244MB ± 0%244MB ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-41.40kB ± 0%1.40kB ± 0%~(all equal)
DecodeCCF/FlowFees.TokensWithdrawn-41.21kB ± 0%1.21kB ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-41.48kB ± 0%1.48kB ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-41.49kB ± 0%1.49kB ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-41.26kB ± 0%1.26kB ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.RewardsPaid-41.38kB ± 0%1.38kB ± 0%~(all equal)
DecodeCCF/FlowToken.TokensDeposited-41.32kB ± 0%1.32kB ± 0%~(all equal)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-41.30kB ± 0%1.30kB ± 0%~(all equal)
DecodeCCF/FlowToken.TokensMinted-41.21kB ± 0%1.21kB ± 0%~(all equal)
DecodeCCF/FlowToken.TokensWithdrawn-41.33kB ± 0%1.33kB ± 0%~(all equal)
DecodeJSON/FlowFees.FeesDeducted-46.00kB ± 0%6.00kB ± 0%~(all equal)
DecodeJSON/FlowFees.TokensWithdrawn-43.60kB ± 0%3.60kB ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-45.43kB ± 0%5.43kB ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-47.35kB ± 0%7.35kB ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-43.64kB ± 0%3.64kB ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.RewardsPaid-44.54kB ± 0%4.54kB ± 0%~(all equal)
DecodeJSON/FlowToken.TokensDeposited-44.88kB ± 0%4.88kB ± 0%~(all equal)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-44.46kB ± 0%4.46kB ± 0%~(all equal)
DecodeJSON/FlowToken.TokensMinted-43.60kB ± 0%3.60kB ± 0%~(all equal)
DecodeJSON/FlowToken.TokensWithdrawn-44.88kB ± 0%4.88kB ± 0%~(all equal)
EncodeBatchEventsCCF-462.4MB ± 0%63.9MB ± 0%~(p=1.000 n=1+1)
EncodeBatchEventsJSON-439.1MB ± 0%40.7MB ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-41.22kB ± 0%1.25kB ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowFees.TokensWithdrawn-41.17kB ± 0%1.20kB ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-41.44kB ± 0%1.47kB ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-41.41kB ± 0%1.44kB ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-41.34kB ± 0%1.38kB ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.RewardsPaid-41.42kB ± 0%1.46kB ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensDeposited-41.22kB ± 0%1.25kB ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-41.20kB ± 0%1.23kB ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensMinted-41.17kB ± 0%1.20kB ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensWithdrawn-41.22kB ± 0%1.25kB ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowFees.FeesDeducted-4864B ± 0%896B ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowFees.TokensWithdrawn-4504B ± 0%536B ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4888B ± 0%920B ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-41.08kB ± 0%1.11kB ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-4552B ± 0%584B ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.RewardsPaid-4752B ± 0%784B ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensDeposited-4776B ± 0%808B ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4640B ± 0%672B ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensMinted-4512B ± 0%544B ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensWithdrawn-4768B ± 0%800B ± 0%~(p=1.000 n=1+1)
ExportType/composite_type-4120B ± 0%120B ± 0%~(all equal)
ExportType/simple_type-40.00B 0.00B ~(all equal)
InterpretRecursionFib-41.19MB ± 0%1.19MB ± 0%~(all equal)
NewInterpreter/new_interpreter-4944B ± 0%944B ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-4200B ± 0%200B ± 0%~(all equal)
ParseArray-42.75MB ± 1%2.78MB ± 0%~(p=0.333 n=2+2)
ParseDeploy/byte_array-44.09MB ± 0%4.17MB ± 2%~(p=0.667 n=2+2)
ParseDeploy/decode_hex-4214kB ± 0%214kB ± 0%~(p=0.667 n=2+2)
ParseFungibleToken/With_memory_metering-429.6kB ± 0%29.6kB ± 0%~(p=0.667 n=2+2)
ParseFungibleToken/Without_memory_metering-429.6kB ± 0%29.6kB ± 0%~(p=1.000 n=2+2)
ParseInfix-41.92kB ± 0%1.92kB ± 0%~(p=1.000 n=2+2)
QualifiedIdentifierCreation/One_level-40.00B 0.00B ~(all equal)
QualifiedIdentifierCreation/Three_levels-464.0B ± 0%64.0B ± 0%~(all equal)
RuntimeScriptNoop-43.37kB ± 0%3.37kB ± 0%~(all equal)
SuperTypeInference/arrays-496.0B ± 0%96.0B ± 0%~(all equal)
SuperTypeInference/composites-40.00B 0.00B ~(all equal)
SuperTypeInference/integers-40.00B 0.00B ~(all equal)
ValueIsSubtypeOfSemaType-448.0B ± 0%48.0B ± 0%~(all equal)
 
allocs/opdelta
DecodeBatchEventsCCF-41.48M ± 0%1.48M ± 0%~(p=1.000 n=1+1)
DecodeBatchEventsJSON-44.70M ± 0%4.70M ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-430.0 ± 0%30.0 ± 0%~(all equal)
DecodeCCF/FlowFees.TokensWithdrawn-426.0 ± 0%26.0 ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-430.0 ± 0%30.0 ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-432.0 ± 0%32.0 ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-426.0 ± 0%26.0 ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.RewardsPaid-429.0 ± 0%29.0 ± 0%~(all equal)
DecodeCCF/FlowToken.TokensDeposited-431.0 ± 0%31.0 ± 0%~(all equal)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-429.0 ± 0%29.0 ± 0%~(all equal)
DecodeCCF/FlowToken.TokensMinted-426.0 ± 0%26.0 ± 0%~(all equal)
DecodeCCF/FlowToken.TokensWithdrawn-431.0 ± 0%31.0 ± 0%~(all equal)
DecodeJSON/FlowFees.FeesDeducted-4126 ± 0%126 ± 0%~(all equal)
DecodeJSON/FlowFees.TokensWithdrawn-471.0 ± 0%71.0 ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4102 ± 0%102 ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4159 ± 0%159 ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-470.0 ± 0%70.0 ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.RewardsPaid-487.0 ± 0%87.0 ± 0%~(all equal)
DecodeJSON/FlowToken.TokensDeposited-495.0 ± 0%95.0 ± 0%~(all equal)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-486.0 ± 0%86.0 ± 0%~(all equal)
DecodeJSON/FlowToken.TokensMinted-471.0 ± 0%71.0 ± 0%~(all equal)
DecodeJSON/FlowToken.TokensWithdrawn-495.0 ± 0%95.0 ± 0%~(all equal)
EncodeBatchEventsCCF-4950k ± 0%998k ± 0%~(p=1.000 n=1+1)
EncodeBatchEventsJSON-4853k ± 0%902k ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-419.0 ± 0%20.0 ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowFees.TokensWithdrawn-419.0 ± 0%20.0 ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-419.0 ± 0%20.0 ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-419.0 ± 0%20.0 ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-419.0 ± 0%20.0 ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.RewardsPaid-419.0 ± 0%20.0 ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensDeposited-420.0 ± 0%21.0 ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-420.0 ± 0%21.0 ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensMinted-419.0 ± 0%20.0 ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensWithdrawn-420.0 ± 0%21.0 ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowFees.FeesDeducted-419.0 ± 0%20.0 ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowFees.TokensWithdrawn-412.0 ± 0%13.0 ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-416.0 ± 0%17.0 ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-425.0 ± 0%26.0 ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-412.0 ± 0%13.0 ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.RewardsPaid-415.0 ± 0%16.0 ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensDeposited-419.0 ± 0%20.0 ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-414.0 ± 0%15.0 ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensMinted-413.0 ± 0%14.0 ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensWithdrawn-418.0 ± 0%19.0 ± 0%~(p=1.000 n=1+1)
ExportType/composite_type-43.00 ± 0%3.00 ± 0%~(all equal)
ExportType/simple_type-40.00 0.00 ~(all equal)
InterpretRecursionFib-418.9k ± 0%18.9k ± 0%~(all equal)
NewInterpreter/new_interpreter-415.0 ± 0%15.0 ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-44.00 ± 0%4.00 ± 0%~(all equal)
ParseArray-459.6k ± 0%59.6k ± 0%~(p=1.000 n=2+2)
ParseDeploy/byte_array-489.4k ± 0%89.4k ± 0%~(p=1.000 n=2+2)
ParseDeploy/decode_hex-463.0 ± 0%63.0 ± 0%~(all equal)
ParseFungibleToken/With_memory_metering-4773 ± 1%773 ± 1%~(p=1.000 n=2+2)
ParseFungibleToken/Without_memory_metering-4773 ± 1%773 ± 1%~(p=1.000 n=2+2)
ParseInfix-448.0 ± 0%48.0 ± 0%~(all equal)
QualifiedIdentifierCreation/One_level-40.00 0.00 ~(all equal)
QualifiedIdentifierCreation/Three_levels-42.00 ± 0%2.00 ± 0%~(all equal)
RuntimeScriptNoop-451.0 ± 0%51.0 ± 0%~(all equal)
SuperTypeInference/arrays-43.00 ± 0%3.00 ± 0%~(all equal)
SuperTypeInference/composites-40.00 0.00 ~(all equal)
SuperTypeInference/integers-40.00 0.00 ~(all equal)
ValueIsSubtypeOfSemaType-41.00 ± 0%1.00 ± 0%~(all equal)
 

@turbolent
Copy link
Member Author

@fxamacker Do you think we should also unexport type fields?

@turbolent turbolent requested a review from fxamacker April 26, 2024 20:47
@turbolent turbolent merged commit e9105b6 into master Apr 30, 2024
10 of 12 checks passed
@turbolent turbolent deleted the bastian/2952-remove-fields-access-by-index branch April 30, 2024 18:04
@turbolent turbolent mentioned this pull request Apr 30, 2024
Closed
@fxamacker
Copy link
Member

fxamacker commented May 1, 2024 •
edited
Loading

@turbolent Amazing work! 👍 Thank you for implementing this!

@fxamacker Do you think we should also unexport type fields?

I will look into #2952 and CCF (hopefully today).

EDIT: Reply and updated comments at #2952

@turbolent turbolent mentioned this pull request May 2, 2024
Closed
6 tasks
@turbolent turbolent mentioned this pull request Jun 20, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsainati1 dsainati1 dsainati1 approved these changes

@SupunS SupunS SupunS approved these changes

@fxamacker fxamacker Awaiting requested review from fxamacker

Assignees

@turbolent turbolent

Labels
Go API Breaking Change Breaks programs which use the Cadence repo as a Go dependency Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove access to fields by index
4 participants
@turbolent @fxamacker @dsainati1 @SupunS