Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export fields of values and types in declaration order #272

Merged
merged 4 commits into from
Jul 28, 2020
Merged

Export fields of values and types in declaration order #272

merged 4 commits into from
Jul 28, 2020

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Jul 28, 2020 •
edited
Loading

⚠️ Depends on #271

Export fields of values and types in declaration order instead of alphabetical order.

See https://axiomzen.slack.com/archives/CTGAW0TM2/p1595506180112200

@turbolent turbolent self-assigned this Jul 28, 2020
psiemens
psiemens approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@psiemens psiemens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice fix 👍

runtime/convertTypes.go Outdated Show resolved Hide resolved
runtime/convertValues.go
t := exportCompositeType(staticType)

// NOTE: use the exported type's fields to ensure fields in type
// and value are in sync
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Base automatically changed from bastian/export-more-types to master July 28, 2020 03:55
@turbolent turbolent merged commit eb75e52 into master Jul 28, 2020
@turbolent turbolent deleted the bastian/export-order branch July 28, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psiemens psiemens psiemens approved these changes

@zhangchiqing zhangchiqing Awaiting requested review from zhangchiqing

@benjaminkvm benjaminkvm Awaiting requested review from benjaminkvm

Assignees

@turbolent turbolent

Labels
Bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turbolent @psiemens