Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add golangci-lint #391

Merged
merged 11 commits into from
Jun 13, 2024
Merged

Add golangci-lint #391

merged 11 commits into from
Jun 13, 2024

Conversation

turbolent
Copy link
Member

Description

  • Add golangci-lint
  • Remove unnecessary and hard to maintain global Makefile
  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent self-assigned this Jun 13, 2024
@turbolent turbolent merged commit b51ee70 into master Jun 13, 2024
10 checks passed
@turbolent turbolent deleted the bastian/lint branch June 13, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SupunS SupunS SupunS approved these changes

@dsainati1 dsainati1 Awaiting requested review from dsainati1

Assignees

@turbolent turbolent

Labels
Chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turbolent @SupunS