Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lint] Remove [Cadence 1.0] from Cadence V1 Diagnostics #315

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Mar 15, 2024

Closes #314

Description

Adding this was an oversight and ends up causing more harm than the value it provides. IMO we should instead rely on clients to add this information if they need it (based on the category), and adding this only pollutes the diagnostic message.

I'll make a PR to add this messaging to the language server after this is merged


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@jribbink jribbink added the Improvement Technical work without new features, refactoring, improving tests label Mar 15, 2024
@SupunS SupunS merged commit 5220936 into master Mar 18, 2024
6 checks passed
@SupunS SupunS deleted the jribbink/c1-diag-update branch March 18, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Technical work without new features, refactoring, improving tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[lint] Remove [Cadence 1.0] prefix from cadence V1 analyzer
3 participants