Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Enable EVM system contract #280

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

m-Peter
Copy link
Contributor

@m-Peter m-Peter commented Jan 31, 2024

Description

The Emulator is now initialized with the emulator.WithEVMEnabled(true), to allow developers to use the EVM system contract in their contracts/scripts/transactions.

NOTE 1: The EVM contract is not yet available for usage in the test script environment, as we need to figure out how to properly setup this environment with the InternalEVM type & value (see https://github.com/onflow/flow-go/blob/master/fvm/evm/stdlib/contract.go#L1570-L1581).

NOTE 1: By setting emulator.WithEVMEnabled(true), the number of accounts upon bootstrapping changes from 4 to 5, due to the fact that a new account is created to hold the storage for the EVM contract. The side effect of this is that developers have to deploy their contracts to addresses starting from 0x0000000000000006 and above.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@turbolent turbolent added Improvement Technical work without new features, refactoring, improving tests Feature and removed Improvement Technical work without new features, refactoring, improving tests labels Feb 1, 2024
@turbolent turbolent merged commit bbf823f into onflow:master Feb 1, 2024
6 checks passed
@m-Peter m-Peter deleted the enable-evm-system-contract branch April 2, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants