Prevent linking to flowscan for unindexed transactions #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d updated click handler to prevent trying to navigate to flowscan for un-indexed activities
tombeckenham
temporarily deployed
to
development
GitHub Actions
Inactive
…url, to handle evm properly, and to handle replace SVG icon with PNG equivalent. Also now shows the address of where the token was sent
tombeckenham
temporarily deployed
to
development
GitHub Actions
Inactive
tombeckenham
temporarily deployed
to
development
GitHub Actions
Inactive
zzggo
approved these changes
Feb 19, 2025
tombeckenham
deleted the
540-bug-activities-shouldnt-link-to-flow-scan-until-indexed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #540
Summary of Changes
Shared TransferItem type, stopped re-hashing indexed transactions as it broke links. Updated click handler to prevent trying to navigate to flowscan for un-indexed activities
Need Regression Testing
Send transaction tests should cover it
Risk Assessment