Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: remove unnecessary data in pubkey return, add type check for pubk #511

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

zzggo
Copy link
Contributor

@zzggo zzggo commented Feb 13, 2025

Related Issue

Closes #510

Summary of Changes

Need Regression Testing

  • Yes
  • No

Added type check and remove unnecessary data in getPubKey function. only allowing pubkey to be used in the frontend.

Risk Assessment

  • Low
  • Medium
  • High

Additional Notes

Screenshots (if applicable)

@zzggo zzggo requested a review from tombeckenham February 13, 2025 03:40
Copy link
Collaborator

@bthaile bthaile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zzggo zzggo merged commit b7134bb into dev Feb 13, 2025
3 checks passed
@zzggo zzggo deleted the 510-feature-remove-unnecessary-data-from-getpubkey branch February 13, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants