481-bug-link-to-flowscan-broken

[tombeckenham]

Related Issue

Closes #481

Summary of Changes

No longer changes hash in transactions. Instead checks evm id and cadence id lists for matching transactions. Frontend tests now use that if they exist to build the ids

Need Regression Testing

Check flowscan for all transaction types

• Yes
• No

Risk Assessment

• Low
• Medium
• High

[Kay-Zee]

Doesn't seem to link correctly when it's an EVM tx. I get sent to the EVM flow scan, but it's using the Cadence tx ID

EDIT: To add a bit more detail, this only happens with the brand new row in the activities column after i send an EVM -> EVM transaction.

Printing out the tx in the ListItemButton's onclick shows the following

Which as you can see, has the cadenceTxId as the hash. which means it will get used as the tx hash when linking out, and since i'm on the "EVM" side of the app, the flowscan URL will be evm.flowscan.

I tested that if i "reload" the extension and activities page, then i get sent to the correct page.

Changing the onClick to:

onClick={() => {
  {
    const txHash = (tx.evmTxIds && tx.evmTxIds.length) === 1 ? tx.evmTxIds[0] : tx.hash;
    const url =
      monitor === 'flowscan'
        ? `${flowscanURL}/tx/${txHash}`
        : `${viewSourceURL}/${txHash}`;
    window.open(url);
  }
}}

does solve the issue for me, but not sure if that's how you want to fix as this makes some assumptions about the tx.evmTxIds array.

[tombeckenham]

I see what you mean. It's possible to have multiple EVM transactions, but think your solution is cleanest

[tombeckenham]

I see what you mean. It's possible to have multiple EVM transactions, but think your solution is cleanest

The alternative would be to have no flowscan url