Add Price formatter and Vis comp #465
Conversation
bthaile
force-pushed
the
add-price-comp
branch
from
ded3c00 to
80bc21f
Compare
…eed to have a separate evm prices call
… to address when fetching evm prices, seems TokenInfo is inconsistent. if price is null or zero show blank
…elp, it's a local file, adding check for evmAddress property
bthaile
force-pushed
the
add-price-comp
branch
from
80bc21f to
2b84363
Compare
| @@ -1174,7 +1174,10 @@ export class WalletController extends BaseController { | |||
|
|
|||
| private async evmtokenPrice(tokeninfo, data) { | |||
| const token = tokeninfo.symbol.toLowerCase(); | |||
| const price = await openapiService.getPricesByEvmaddress(tokeninfo.address, data); | |||
There was a problem hiding this comment.
I noticed that tokenInfo address was the cadence address and evmAddress was a property on TokenInfo. In effect it was a bug.
There was a problem hiding this comment.
Please confirm if 0.0001 is 0.0 (sub 3) 1 or 0.0 (sub 4) 1. You've implemented it as 0.0 (sub 3) 1 but at the very least there are some communties that believe this should be sub 4 - indicating 4 zeros. Please confirm where you've seen this notation before this is merged.
|
@tombeckenham I think what you're trying to say is actually that: 0.00001 should be 0.0(subscript4)1, and not 0.0(subscript3)1 that the code currently does. (it's just your example used 0.0001) 
Think of it as if we're talking chemistry. H(subscript2)0 means theres 2 H's, including the one that's written, so 0.0(subscript 4)1 means there are 4 zeros, including the one displayed. The only thing that has to change is remove the minus 1 in the total zeros - 1. |
|
Updated PR to use correct scientific notion subscripts |
Related Issue
Closes #454
Adds formatting price or value to create a subscript
Used on coin list page
Used on activities page
Added tests for formatting value helper
Summary of Changes
Addes helper to format prices,
Need Regression Testing
Risk Assessment
Additional Notes
This only a UI component with helper method and tests. It's not been integrated into the existing UI.
Screenshots (if applicable)
using scientific subscript notation. 0.0(4)12 means four zeros after decimal