436 feature complete type checks on token transactions #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
tombeckenham
reviewed
Feb 5, 2025
The tests covering these functions should be inside sendTransaction. Currently, the live version only contains EVM transactions. Missing COA to flow, flow to flow, and flow to COA. |
…nsactions # Conflicts: # src/ui/views/Send/TransferConfirmation.tsx
…nsactions # Conflicts: # src/ui/views/InnerRoute.tsx
bthaile
reviewed
Feb 13, 2025
tombeckenham
temporarily deployed
to
development
GitHub Actions
Inactive
… around integer strings and added tests.
tombeckenham
temporarily deployed
to
development
GitHub Actions
Inactive
tombeckenham
temporarily deployed
to
development
GitHub Actions
Inactive
tombeckenham
temporarily deployed
to
development
GitHub Actions
Inactive
tombeckenham
temporarily deployed
to
development
GitHub Actions
Inactive
tombeckenham
had a problem deploying
to
development
GitHub Actions
Failure
tombeckenham
temporarily deployed
to
development
GitHub Actions
Inactive
tombeckenham
had a problem deploying
to
development
GitHub Actions
Failure
tombeckenham
temporarily deployed
to
development
GitHub Actions
Inactive
tombeckenham
temporarily deployed
to
development
GitHub Actions
Inactive
…e-type-checks-on-token-transactions' into 436-feature-complete-type-checks-on-token-transactions
tombeckenham
temporarily deployed
to
development
GitHub Actions
Inactive
tombeckenham
temporarily deployed
to
development
GitHub Actions
Inactive
tombeckenham
temporarily deployed
to
development
GitHub Actions
Inactive
tombeckenham
deleted the
436-feature-complete-type-checks-on-token-transactions
branch
tombeckenham
had a problem deploying
to
development
GitHub Actions
Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #436
Summary of Changes
Need Regression Testing
Added missing type checks on the current transaction functions
Risk Assessment
Additional Notes
Screenshots (if applicable)