Add price and keystore import tips #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmcmz
requested changes
Apr 3, 2024
src/background/controller/wallet.ts
Outdated
| @@ -975,6 +988,12 @@ export class WalletController extends BaseController { | |||
| return Promise.resolve({ | |||
| price: { last: '1.0', change: { percentage: '0.0' } }, | |||
| }); | |||
| case 'dust': | |||
There was a problem hiding this comment.
Why we need this ? It looks like no extendable.
Please use token contract name instead of token name.
src/background/service/openapi.ts
Outdated
| `/api/prices`, | ||
| {}, | ||
| {}, | ||
| 'https://test.lilico.app' |
There was a problem hiding this comment.
For production, it's different endpoint. Put it in ENV file
src/background/service/openapi.ts
Outdated
| 'https://test.lilico.app' | ||
| ); | ||
|
|
||
| if (pricesMap && pricesMap['FlovatarDustToken']) { |
There was a problem hiding this comment.
Why we need handle FlovatarDustToken separately ?
| @@ -168,6 +180,11 @@ const JsonImport = ({ onOpen, onImport, setPk, isSignLoading }) => { | |||
| </Typography> | |||
| </Button> | |||
| </form> | |||
| {errorMesssage && ( | |||
| <Alert severity="warning"> | |||
There was a problem hiding this comment.
Refer to our default error message in design, do not use alert.
| @@ -168,6 +180,11 @@ const JsonImport = ({ onOpen, onImport, setPk, isSignLoading }) => { | |||
| </Typography> | |||
| </Button> | |||
| </form> | |||
| {errorMesssage && ( | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.