295 feature remove metamask and rabby wallet dependencies #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombeckenham
approved these changes
Dec 20, 2024
tombeckenham
approved these changes
Dec 20, 2024
zzggo
deleted the
295-feature-remove-metamask-and-rabby-wallet-dependencies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Summary of Changes
Need Regression Testing
Removed the requirements of rabby and metamask libraries for keyrings and sign typed data.
Risk Assessment
Keyring update is related with user login and register, need to go through different login and register process to ensure safety.
Additional Notes
Changes made: change the store from metamask with a local store structure, changed the rabby keyring structure with ethers keyring. Updated signtype data eip712hash from metamask to encoding using ethers.
Screenshots (if applicable)