232 feature decode evm transaction call data for user readability #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for-user-readability # Conflicts: # src/background/controller/wallet.ts
tombeckenham
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
The code looks fine, but I have no idea what it does. It might be a good idea for @hao to approve
zzggo
deleted the
232-feature-decode-evm-transaction-call-data-for-user-readability
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Summary of Changes
Need Regression Testing
Updated the confirm page of the sign transaction popup
Risk Assessment
Ui changes and data display, won't affect transaction
Additional Notes
tested here on rainbow test
Screenshots (if applicable)