233-feature-firebase-auth-for-web-extensions #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombeckenham
temporarily deployed
to
production
GitHub Actions
Inactive
lmcmz
approved these changes
Dec 17, 2024
tombeckenham
deleted the
233-feature-firebase-auth-for-web-extensions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #233
Summary of Changes
Changed Firebase auth import to auth/web-extension
Need Regression Testing
Changes the way auth is loaded, and changed the webpack configuration
Risk Assessment
Potential to block Chrome store submission if the change didn't work. I believe it has, and have checked the code output during build