Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOT FIX - content script wallet connect issue #281

Merged

Conversation

tombeckenham
Copy link
Collaborator

Related Issue

Closes #280

Summary of Changes

Removed inclusion of fcl library in script.js
Bumped to version 2.6.3

Need Regression Testing

  • Yes
  • No

Risk Assessment

This removed unnecessary inclusion of the full fcl library in a script that was simply injecting a service definition

  • Low
  • Medium
  • High

Copy link
Contributor

@lmcmz lmcmz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Catch

@tombeckenham tombeckenham merged commit e2c965c into master Dec 12, 2024
2 checks passed
@tombeckenham tombeckenham deleted the 280-HOT-FIX---content-script-wallet-connect-issue branch December 12, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HOT FIX - content script wallet connect issue
3 participants