Move and register page refactor #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/ui/views/AddWelcome/AddRegister/SetPassword.tsx # src/ui/views/LandingPages/Reset/RecoverPassword.tsx # src/ui/views/Register/AllSet.tsx # src/ui/views/Sync/SyncQr.tsx # src/ui/views/WelcomePage/index.tsx
src/ui/FRWComponent/LandingPages/ImportComponents/Googledrive.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
50
to
54
| history.push({ | ||
| pathname: '/import/google', | ||
| pathname: '/welcome/accountimport/google', | ||
| state: { | ||
| accounts: accounts, | ||
| }, |
There was a problem hiding this comment.
I'd prefer you told the view containing this component to navigate. Hard coding a route makes it hard to re-use components.
| @@ -131,9 +131,9 @@ const PasswordIndicator = (props) => { | |||
| ); | |||
| }; | |||
|
|
|||
| const SetPassword = ({ handleClick, mnemonic, username, lastPassword }) => { | |||
| const SetPassword = ({ handleSwitchTab, mnemonic, username, lastPassword }) => { | |||
There was a problem hiding this comment.
Component name should match file name
|
|
||
| import DecryptWallet from './DecryptWallet'; | ||
| import GoogleAccounts from './GoogleAccounts'; | ||
| import RecoveryPassword from './GoogleRecoverPassword'; |
There was a problem hiding this comment.
Component name should match file name
| @@ -128,9 +128,9 @@ const PasswordIndicator = (props) => { | |||
| ); | |||
| }; | |||
|
|
|||
| const SetPassword = ({ handleClick, mnemonic, pk, tempPassword, goEnd, accountKey }) => { | |||
| const SetPassword = ({ handleSwitchTab, mnemonic, pk, tempPassword, goLast, accountKey }) => { | |||
There was a problem hiding this comment.
Component name should match file name. It should be RecoveryPassword not RecoverPassword (or SetPassword)
tombeckenham
requested changes
Dec 20, 2024
tombeckenham
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Summary of Changes
Need Regression Testing
Risk Assessment
Additional Notes
Screenshots (if applicable)