94-event-tracking-add-mixpanel-event-tracking #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombeckenham
temporarily deployed
to
production
GitHub Actions
Inactive
lmcmz
approved these changes
Nov 30, 2024
tombeckenham
temporarily deployed
to
production
GitHub Actions
Inactive
tombeckenham
temporarily deployed
to
production
GitHub Actions
Inactive
tombeckenham
deleted the
94-event-tracking-add-mixpanel-event-tracking
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seperated UI, content, and background so that UI services aren't accidentally added to the background script. I added ESlint config to catch imports.
Note the passkey stuff has a lot of mixing of bits and pieces. It needs to be cleaned up. I've ignored most of that.
I then corrected the messaging between the background script and UI and added comments to clarify what eventBus does. I still think this system could be improved.
Finally I fixed the page tracking in MixPanel so that it works automatically with single page web apps and captures changes to the hash in the URL. This will track all page views correctly.
This is going to be great. We'll get a full view of what's going on in the extension.
Fixes #94