Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cachePathForKey public [resolves #255] #256

Merged
merged 1 commit into from
Feb 28, 2016

Conversation

jasonnoahchoi
Copy link
Contributor

Understandably, the method was private; however, this commit solves the problem of anyone that requires access to the actual file path of the cached image. This is especially useful for projects that are building iOS apps that are showing content with UIWebViews and lacks access to Internet connection.

Ref: #255

@codecov-io
Copy link

Current coverage is 76.90%

Merging #256 into master will not affect coverage as of b0dcce2

@@            master   #256   diff @@
=====================================
  Files           11     11       
  Stmts         1260   1260       
  Branches         0      0       
  Methods          0      0       
=====================================
  Hit            969    969       
  Partial          0      0       
  Missed         291    291       

Review entire Coverage Diff as of b0dcce2

Powered by Codecov. Updated on successful CI builds.

@onevcat
Copy link
Owner

onevcat commented Feb 28, 2016

Thanks, it makes sense.

onevcat added a commit that referenced this pull request Feb 28, 2016
@onevcat onevcat merged commit 55e9049 into onevcat:master Feb 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants