Introduce a custom image source provider to enable third-party image processors to utilize AnimatedImageView. #2094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y image processors to utilize AnimatedImageView.
|
At the first glance, it is coooool. Thanks for this. I will take a detail look at it ASAP. |
|
It appears that the check failed because of a network connection issue. I tested it on my machine and all tests were passed successfully. |
|
Don't worry about it! I guess it is something related to the low spec of GH's node and the shared resource. It sometimes fails at the first time. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this update, third-party image processors were unable to create animated images without relying on
UIImage.animatedImage, which is only available on iOS and can consume a significant amount of memory.This pull request addresses the problem by introducing a new protocol called
ImageFrameSourceand refactoringAnimatedImageViewto utilize it.Relevant issue:
yeatse/KingfisherWebP#41
yeatse/KingfisherWebP#39