-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AVAssetImageDataProvider.swift #1951
Conversation
I used the kingfisher for generating the image asset but after generating the image asset, I got the rotated image and then I just added the below line in your file and it worked perfectly fine. "generator.appliesPreferredTrackTransform = true" This is the code I used to get the image from the video URL:- let provider = AVAssetImageDataProvider(assetURL: URL(string: videoUrl)!, seconds: 1) Please review the changes and approve the same. |
I guess it is not a bad default! |
Hey @onevcat, I tried the code using the default functionality but it gives me the rotated image as a result, once we set this property True, only then we get the correct result. - generator.appliesPreferredTrackTransform = true You can implement it at your end, just to review the same. I'm attaching a reference link where many of the users got the same error, without setting this property to True. Related question reference Link:- Related answer reference Link:- |
Oh, I meant setting it to true would be a good idea as “new default”! Thanks for the PR. |
Thanks for merging the code :) |
Hey @onevcat, I just tried updating the pod and even I tried to add your library using Swift package manager, but I couldn't find the updated changes. Do I need to update something else? |
Merging it to the master branch does not mean a new release. Unless you are explicitly pointing to the I will tag these changes in a few minutes and then you can try again to upgrade to a new release. |
Okay Thanks, I will wait for the new release. |
7.2.3 was just released for this. |
Thanks for the new release. |
No description provided.