Error image with custom Placeholder fix #1925
Merged
+28
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance of this being looked at? |
|
@PJ-LT Sorry for the late reply. It looks good to me and I was just a bit busy recently on other projects. I will merge and tag it ASAP! Thanks for the contribution! |
|
@onevcat Awesome, thanks so much! |
Comment on lines
55
to
+61
| CallbackQueue.mainCurrentOrAsync.execute { | ||
| context.onFailureDelegate.call(KingfisherError.imageSettingError(reason: .emptySource)) | ||
| if let image = context.options.onFailureImage { | ||
| self.loadedImage = image | ||
| } | ||
| self.loading = false | ||
| self.loaded = true |
There was a problem hiding this comment.
Don't we need to pass weak or unowned self here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where custom Placeholders are never removed when an error occurs even when there is an Error Image that should be shown instead.
Steps to reproduce:
Note: Unit Test added for UIKit failed without fix and passes with fix