Start loading when evaluating view #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1821
Currently the loading will not start until the
onAppearof the placeholder shown, which is too late for a sync loading from disk or memory. It causes an unwanted flickering. This PR moves the loading starting earlier to the beginning ofKFImageRenderer.body. The loading method call (and its states inImageBinder) is protected by the main thread, so it would not actually run more than once, which should be pretty light.Also added a
loadingproperty to prevent situations that image loading without an actual downloading process (say, applying a processor to a cached image). Before this fix, it will be recognized as "notloadingOrSucceeded" and triggers multiple start loading behaviors since thebodywill be evaluated for multiple times.