Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added an attribute to fix error on mac catalyst #1692

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

kvyatkovskys
Copy link
Contributor

Hello. I have the bug on Mac catalyst. Added a little bit fix

Screenshot 2021-04-21 at 11 25 31

@onevcat
Copy link
Owner

onevcat commented Apr 21, 2021

@kvyatkovskys Thanks for this. May I know the Xcode version you are using? I guess it is more likely a compiler version issue and I want to reproduce it.

@kvyatkovskys
Copy link
Contributor Author

kvyatkovskys commented Apr 21, 2021

@kvyatkovskys Thanks for this. May I know the Xcode version you are using? I guess it is more likely a compiler version issue and I want to reproduce it.

sure, we use Xcode Version 12.0 (12A7209) for our Mac catalyst project
also reproduced for Kingfisher project

Works fine on Xcode Version 12.4 (12D4e)

@onevcat
Copy link
Owner

onevcat commented Apr 21, 2021

Umm, I guess it is a change in Swift 5.3.1 (Xcode 12.2). I guess it should be no harm to add the tag explicitly,. I will download an older version of Xcode and verify the fix. Stay tuned!

@onevcat
Copy link
Owner

onevcat commented Apr 21, 2021

I tried Xcode 12.0 and 12.1, but without reproducing this issue. That is weird.

I guess it should be no harm to add the @ViewBuilder annotation here, but I am really curious on what is going on.

Do you have any chance to try clean the project and build again?

@kvyatkovskys
Copy link
Contributor Author

Very strange 🤔
Yep, cleaned the project... Reproduced every time for me 😕

@onevcat
Copy link
Owner

onevcat commented Apr 22, 2021

Anyway, let's merge it and see what could happen. Thanks!

@onevcat onevcat merged commit 7af80eb into onevcat:master Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants