Enable Define Module in Build Settings #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ingfisher in libraries imported in objc project.
3 tasks
|
It seems that this PR fails the build now. I am not sure about the impact on current projects if we apply this. But I'd like to keep an eye to see the possibility. |
…entary with the DEFINE_MODULES
|
@onevcat, I've fixed the broken build. I had to enable CLANG_ENABLE_MODULES, a setting complementary with the DEFINE_MODULES. A good impact of these changes, is that we'll be able to use Kingfisher in hybrid contexts without the need to manually inject a modulemap :). |
skoduricg
pushed a commit
to rentpath/Kingfisher
that referenced
this pull request
Sep 24, 2021
Enable Define Module in Build Settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale:
Enabling "Define Module" will trigger an automatic generation of the module.modulemap (https://clang.llvm.org/docs/Modules.html#id16), essential file to be able to use Kingfisher in libraries (that expose Kingfisher interfaces), which in turn will be used by Obj-c libraries/apps.
This is affecting both SPM and Carthage usage, not CocoaPods since the latter will enable 'Define Module' in case of hybrid (objc-swift) consumer apps.