feat(ansible): add branch reference as variable in gitrepository #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/kubernetes
|
I like this, however it should be defaulted to the main branch if not set. |
oscaromeu
force-pushed
the
feat/add-branch-variable
branch
from
044cde3 to
a18dc4a
Compare
|
Hi @onedr0p, I updated the PR with your suggestion, let me know if is there anything more. Thank you!! |
onedr0p
reviewed
Aug 27, 2023
|
Thanks for the feature add! 🙂 |
|
Thank you! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Flux GitRepository kind allows for configuring the branch reference. Currently, the value is fixed at 'main' in the 'flux-cluster-template' project. This pull request allows configuring the desired branch to be used in the GitRepository manifest.
The code has been tested with different values for the variable
bootstrap_github_repository_branchand the results were correct. Let me know if you need this results.