Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove email from config and cert manager #1738

Merged
merged 4 commits into from
Jan 31, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/tests/config-talos.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ cloudflare:
domain: fake
token: take
acme:
email: [email protected]
production: false
tunnel:
account_id: fake
Expand Down
2 changes: 0 additions & 2 deletions config.sample.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,6 @@ cloudflare:
token: ""
# (REQUIRED) Optionals for Cloudflare Acme
acme:
# (REQUIRED) Any email you want to be associated with the ACME account (used for TLS certs via letsencrypt.org)
email: ""
# (REQUIRED) Use the ACME production server when requesting the wildcard certificate.
# By default the ACME staging server is used. This is to prevent being rate-limited.
# Update this option to `true` when you have verified the staging certificate
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ metadata:
spec:
acme:
server: https://acme-v02.api.letsencrypt.org/directory
email: "${SECRET_ACME_EMAIL}"
privateKeySecretRef:
name: letsencrypt-production
solvers:
Expand All @@ -28,7 +27,6 @@ metadata:
spec:
acme:
server: https://acme-staging-v02.api.letsencrypt.org/directory
email: "${SECRET_ACME_EMAIL}"
privateKeySecretRef:
name: letsencrypt-staging
solvers:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ metadata:
#% if cloudflare.enabled %#
stringData:
SECRET_DOMAIN: "#{ cloudflare.domain }#"
SECRET_ACME_EMAIL: "#{ cloudflare.acme.email }#"
SECRET_CLOUDFLARE_TUNNEL_ID: "#{ cloudflare.tunnel.id }#"
#% else %#
stringData: {}
Expand Down