fix(metrics-server): Remove --kubelet-insecure-tls #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://www.talos.dev/v1.6/kubernetes-guides/configuration/deploy-metrics-server, this flag is not necessary when enabling certificate rotation and an auto CSR approver.
|
Unfortunately k3s still needs this set, you can either wrap it in an if block or we can leave it there as is. |
What is k3s? :kekw: |
onedr0p
approved these changes
Mar 27, 2024
|
Thanks for applying the fix! Was going to get to it later tonight 🥈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://www.talos.dev/v1.6/kubernetes-guides/configuration/deploy-metrics-server, this flag is not necessary when enabling certificate rotation and an auto CSR approver.