Add the option for assigning a specific SSH key to a node. #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onedr0p
reviewed
Mar 4, 2024
onedr0p
reviewed
Mar 4, 2024
onedr0p
reviewed
Mar 4, 2024
onedr0p
reviewed
Mar 4, 2024
onedr0p
approved these changes
Mar 4, 2024
|
I made a few changes, otherwise looks good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I personally prefer to store key as a named value in my
~/.ssh/directory, but the configs have no way of allowing for that (or at least I wasn't able to find any) - this should account for it, and only set it when that variable has been specified.It was my first time editing jinja templates, so I hope it's fine - it works a-okay on my end.