-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: removal of all addons #1247
Conversation
Signed-off-by: Devin Buhl <[email protected]>
Signed-off-by: Devin Buhl <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SHIP IT
LGTM 🚀 I 100% agree. I think addons should be community maintained, if at all. The idea of the template is to get a cluster up and running. You don't learn anything if you have the entire thing handed to you on a platter. |
Maybe in the future some of the addons removed here could be added as core components (e.g. system-upgrade-controller) but for now it's better to axe them and circle back on it later with a discussion why something should be included by default. |
Signed-off-by: Devin Buhl <[email protected]>
LGTM 😄 |
suggestion the namespacing: would it make sense to prefix the namespaces that are created by this template? (e.g. |
I'm seeing so many different opinions out there on naming it's hard to be consistent (e.g. longhorn recommends longhorn-system, volsync recommends volsync-system, then there is flux-system as well :/) Here's my thought and it's probably wild but maybe suffix with -system for operator only namespaces and then prefix with system for grouping non operator cluster based apps. |
Signed-off-by: Devin Buhl <[email protected]>
I know this PR will be greeted with mixed reviews but here's my reasons for excluding all the addons:
task configure
. I would like to build out the core components in a way that makes it so they are somewhat customizable to prevent clobbering of the files. Doing that with the addons would require too much work, logic, spaghetti and testing.With that said, in the future I can foresee a community maintained repository for addons that would compliment this repo but for now I would like to focus on testing the core distros and components and revamping the config file.
Other changes:
openebs-system
namespace and renamestools
ns tosystem-tools
127.0.0.1
in the cilium config