Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added longhorn addon #1204

Merged
merged 6 commits into from
Jan 20, 2024
Merged

feat: added longhorn addon #1204

merged 6 commits into from
Jan 20, 2024

Conversation

brunnels
Copy link
Contributor

Fixes #1196

onedr0p
onedr0p requested changes Jan 19, 2024
View reviewed changes
Copy link
Owner

@onedr0p onedr0p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .github/tests/addons.yaml file needs to be updated with setting longhorn enabled

@github-actions github-actions bot added the area/github Changes made in the github directory label Jan 19, 2024
onedr0p
onedr0p requested changes Jan 19, 2024
View reviewed changes
Copy link
Owner

@onedr0p onedr0p left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should go with longhorn-system as the namespace. This is the default one they recommend. Plus this spawns a ton of pods and it's nice to have that in it's own ns.

@onedr0p onedr0p merged commit 8a840e1 into main Jan 20, 2024
7 checks passed
@onedr0p onedr0p deleted the add-longhorn-addon branch January 20, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onedr0p onedr0p onedr0p approved these changes

Assignees
No one assigned
Labels
area/github Changes made in the github directory type/minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add longhorn as a addon
2 participants
@brunnels @onedr0p