Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OmniAuth 2.0 #44

Merged
merged 2 commits into from
Jan 19, 2021
Merged

Add support for OmniAuth 2.0 #44

merged 2 commits into from
Jan 19, 2021

Conversation

jkowens
Copy link
Contributor

@jkowens jkowens commented Jan 16, 2021

Hoping this helps the Devise team as they work on releasing an update to support OmniAuth 2.0.

See: heartcombo/devise#5326 (comment)

@jkowens
Copy link
Contributor Author

jkowens commented Jan 17, 2021

@BobbyMcWho would you be able to review this PR? Sorry I know you’ve been busy 😬

@BobbyMcWho
Copy link
Member

@jkowens sure, sorry I don't get notifications in this repo on activity. I'll take a look today as soon as I can, and I'll figure out who I need to herd to get this released on rubygems.

@BobbyMcWho
Copy link
Member

It looks like @mbleigh is the owner on rubygems

@BobbyMcWho
Copy link
Member

@jkowens Just need the version file update committed since it looks like the Gemfile.lock has this gem bumped to 2.0.0?

@jkowens
Copy link
Contributor Author

jkowens commented Jan 17, 2021

@BobbyMcWho I think the reason for the version change in Gemfile.lock is because the gem was released as 2.0, but I don't think the Gemfile.lock had been updated.

@BobbyMcWho
Copy link
Member

Ah you're correct, the main branch has v2.0.0 but it's never been released on rubygems.

@carlosantoniodasilva
Copy link

Thank you both for your work on this! ❤️

@BobbyMcWho BobbyMcWho merged commit 8ee8ef3 into omniauth:master Jan 19, 2021
@BobbyMcWho
Copy link
Member

I'll release this as 2.0.0 later, I need to do some history digging and see what has been merged since the last rubygems release was cut.

@BobbyMcWho
Copy link
Member

@carlosantoniodasilva @jkowens I released it as v2.0.1 just to be safe.

@carlosantoniodasilva
Copy link

Perfect, thanks. I'll look into the devise updates next, hopefully this week still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants