-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for OmniAuth 2.0 #44
Conversation
3e9cb20
to
08cd655
Compare
@BobbyMcWho would you be able to review this PR? Sorry I know you’ve been busy 😬 |
@jkowens sure, sorry I don't get notifications in this repo on activity. I'll take a look today as soon as I can, and I'll figure out who I need to herd to get this released on rubygems. |
It looks like @mbleigh is the owner on rubygems |
@jkowens Just need the version file update committed since it looks like the Gemfile.lock has this gem bumped to 2.0.0? |
@BobbyMcWho I think the reason for the version change in Gemfile.lock is because the gem was released as 2.0, but I don't think the Gemfile.lock had been updated. |
Ah you're correct, the main branch has v2.0.0 but it's never been released on rubygems. |
Thank you both for your work on this! ❤️ |
I'll release this as 2.0.0 later, I need to do some history digging and see what has been merged since the last rubygems release was cut. |
@carlosantoniodasilva @jkowens I released it as v2.0.1 just to be safe. |
Perfect, thanks. I'll look into the devise updates next, hopefully this week still. |
Hoping this helps the Devise team as they work on releasing an update to support OmniAuth 2.0.
See: heartcombo/devise#5326 (comment)