Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list of nestes dataclass parsing and NotRequired having inspect._empty as default #625

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

mauvilsa
Copy link
Member

What does this PR do?

Fixes #614

Before submitting

  • Did you read the contributing guideline?
  • [n/a] Did you update the documentation? (readme and public docstrings)
  • Did you write unit tests such that there is 100% coverage on related code? (required for bug fixes and new features)
  • Did you verify that new and existing tests pass locally?
  • Did you make sure that all changes preserve backward compatibility?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

…rse.

- Fix NotRequired incorrectly having inspect._empty as default.
@mauvilsa mauvilsa added the bug Something isn't working label Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (150caf8) to head (b18f77e).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #625   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         6493      6491    -2     
=========================================
- Hits          6493      6491    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mauvilsa mauvilsa changed the title Fix list of dataclass with nested dataclass attribute failing and NotRequired incorrectly having inspect._empty as default Fix list of nestes dataclass parsing and NotRequired having inspect._empty as default Nov 18, 2024
@mauvilsa mauvilsa merged commit 3f4a80b into main Nov 19, 2024
29 checks passed
@mauvilsa mauvilsa deleted the issue-614-list-nested-data-class-required-attr branch November 19, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing to a list of dataclasses with nested dataclass fails
1 participant