Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PEP 692 #586

Merged
merged 13 commits into from
Oct 11, 2024
Merged

Conversation

a-gardner1
Copy link
Contributor

@a-gardner1 a-gardner1 commented Oct 1, 2024

What does this PR do?

Adds support for PEP 692 (closes #579)

Before submitting

  • Did you read the contributing guideline?
  • Did you update the documentation? (readme and public docstrings)
  • Did you write unit tests such that there is 100% coverage on related code? (required for bug fixes and new features)
  • Did you verify that new and existing tests pass locally?
  • Did you make sure that all changes preserve backward compatibility?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4363650) to head (a0d6ece).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #586   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         6451      6488   +37     
=========================================
+ Hits          6451      6488   +37     
Flag Coverage Δ
py3.10 85.78% <64.28%> (-0.13%) ⬇️
py3.10_all 98.84% <100.00%> (+<0.01%) ⬆️
py3.10_pydantic1 49.18% <57.14%> (+0.01%) ⬆️
py3.10_pydantic2 48.96% <57.14%> (+0.01%) ⬆️
py3.10_types 98.85% <100.00%> (+<0.01%) ⬆️
py3.11 85.97% <97.61%> (+0.09%) ⬆️
py3.11_all 98.79% <100.00%> (+<0.01%) ⬆️
py3.11_types 98.81% <100.00%> (+<0.01%) ⬆️
py3.12 86.12% <97.61%> (+0.09%) ⬆️
py3.12_all 98.79% <97.61%> (-0.01%) ⬇️
py3.12_types 98.81% <97.61%> (-0.01%) ⬇️
py3.8 86.41% <64.28%> (-0.13%) ⬇️
py3.8_all 99.47% <100.00%> (+<0.01%) ⬆️
py3.8_types 99.50% <100.00%> (+<0.01%) ⬆️
py3.9 86.34% <64.28%> (-0.13%) ⬇️
py3.9_all 99.42% <100.00%> (+<0.01%) ⬆️
py3.9_types 99.44% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jsonargparse_tests/test_typehints.py Fixed Show resolved Hide resolved
@a-gardner1 a-gardner1 marked this pull request as ready for review October 2, 2024 21:38
jsonargparse/_parameter_resolvers.py Outdated Show resolved Hide resolved
jsonargparse/_parameter_resolvers.py Outdated Show resolved Hide resolved
jsonargparse/_parameter_resolvers.py Outdated Show resolved Hide resolved
jsonargparse/_parameter_resolvers.py Outdated Show resolved Hide resolved
jsonargparse_tests/test_typehints.py Fixed Show resolved Hide resolved
jsonargparse_tests/test_typehints.py Outdated Show resolved Hide resolved
jsonargparse_tests/test_typehints.py Outdated Show resolved Hide resolved
jsonargparse_tests/test_typehints.py Outdated Show resolved Hide resolved
jsonargparse_tests/test_typehints.py Outdated Show resolved Hide resolved
CHANGELOG.rst Outdated Show resolved Hide resolved
CHANGELOG.rst Outdated Show resolved Hide resolved
Copy link

@mauvilsa mauvilsa merged commit 2160982 into omni-us:main Oct 11, 2024
27 checks passed
@a-gardner1 a-gardner1 deleted the wip-support-unpack-typeddict branch October 14, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for PEP 692: **kwargs: typing.Unpack[TypedDict]
2 participants