Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import path of inherited classmethod not resolving correctly #548

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

mauvilsa
Copy link
Member

What does this PR do?

Fixes Lightning-AI/pytorch-lightning#19863 (reply in thread)

Before submitting

  • Did you read the contributing guideline?
  • [n/a] Did you update the documentation? (readme and public docstrings)
  • Did you write unit tests such that there is 100% coverage on related code? (required for bug fixes and new features)
  • Did you verify that new and existing tests pass locally?
  • Did you make sure that all changes preserve backward compatibility?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

@mauvilsa mauvilsa added the bug Something isn't working label Jul 12, 2024
Copy link

@mauvilsa mauvilsa merged commit ed25652 into main Jul 12, 2024
26 checks passed
@mauvilsa mauvilsa deleted the pl-discussion-19863-classmethod-import-path branch July 12, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant