Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider parameters of type POSITIONAL_OR_KEYWORD as KEYWORD if only **kwargs present #98

Closed
florianblume opened this issue Nov 9, 2021 · 1 comment
Closed

Consider parameters of type POSITIONAL_OR_KEYWORD as KEYWORD if only **kwargs present #98

florianblume opened this issue Nov 9, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@florianblume
Copy link

When not providing default values for any method or function argument, i.e. having only POSITIONAL_OR_KEYWORD arguments, the parameters should be considered KEYWORD in case that the method or function signature only has **kwargs and not *args. (Taken from our Slack discussion).
@mauvilsa mauvilsa added the enhancement New feature or request label Nov 9, 2021
mauvilsa added a commit that referenced this issue Jun 10, 2022
@mauvilsa
- Added signature parameters resolving by inspecting the source code …
2293160 
…with ASTs, pytorch-lightning#11653.

- Some refactoring mostly related to the new AST support.
- Parameters of type POSITIONAL_OR_KEYWORD now considered KEYWORD #98.
- dataclasses no longer an optional, now an install require on python 3.6.
- JSONARGPARSE_DEBUG now also sets the reconplogger level to DEBUG.
@mauvilsa
Copy link
Member

With the current version in master it should now be working like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@florianblume @mauvilsa