No error message when using ArgumentParser.instantiate_classes()

[yunxie12]

Hello, I found some odd codes at

jsonargparse/jsonargparse/core.py

Line 1111 in 57741c2

except KeyError:

.
I am confused why KeyError should be ignored. When instantiating a class, KeyError is common, for example, try to get a value from a dict using a nonexistent key. It takes me lots of time to debug my code with KeyError.
Anyway, jsonargparse is a great package and help me a lot.
I wish we can discuss my confusion.

[mauvilsa]

I think you are right, that is a mistake. The try should only wrap the _get_key_value line and only if no exception the rest would be executed. Would you like to create a pull request with the fix?

[mauvilsa]

Since there was no response I went ahead and fixed it. Currently in master and will be part of the next release. @yunxie12 please try again with jsonargparse from master your code in which the instantiation gave KeyError to verify that the fix worked.

[yunxie12]

The fix works. Thanks you!