-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support optional comment header for printed configs #79
Comments
Can you please explain more. Is the comment header one for the whole printed yaml? Why a function and based on what the string that returns changes? Note that comments coming from docstrings are already included by using |
The idea is to be able to add some metadata to the config file for reproducibility. For Lightning, it could include the version when the config file was generated: # Lightning version: v1.4.1
trainer:
...
model:
...
Yes
Actually this is not a hard requirement so passing the string directly is okay
This would be okay as long as
Although you could also expect that if this metadata/header is passed to the parser, it should be included in the config by default |
This has been implemented in commit 00f42e0. Based on the described use case it didn't make sense to have a switch in |
Pitch
Allow passing a function that returns an
str
so the config generated with--print_config
has a comment header with that string.This would be useful to save which version was used to generate a config inside the config itself.
The text was updated successfully, but these errors were encountered: