Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple default_config_files default values #58

Closed
stasbel opened this issue May 21, 2021 · 4 comments
Closed

Multiple default_config_files default values #58

stasbel opened this issue May 21, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@stasbel
Copy link

stasbel commented May 21, 2021

Say, I want to set defaults from two config files with keys intersection.
I expect it to set defaults with each next config in the list override previous values.
But instead, it says:

default config file locations:
  ['config1.yaml', 'config2.yaml'], Note:
  default values below will be ones overridden by the contents of:
  config1.yaml

Which completely ignores information from config2.yaml.
Why is it expected behavior and could it be fixed?
Thanks.
@stasbel stasbel changed the title Multiple default_config_files Multiple default_config_files default values May 21, 2021
@mauvilsa
Copy link
Member

It is like this just because it hasn't been implemented. Surely it could be implemented.

@mauvilsa mauvilsa added the enhancement New feature or request label May 25, 2021
@stasbel
Copy link
Author

stasbel commented Jun 21, 2021

hi, any progress on this?

@mauvilsa
Copy link
Member

Sorry @stasbel I haven't worked on this. Currently there are other higher priority tasks in jsonargparse. You will have to wait a bit for me to have time for it.

@alexpolozov alexpolozov mentioned this issue Jun 28, 2021
Closed
mauvilsa added a commit that referenced this issue Jul 5, 2021
@mauvilsa
- Added lazy_instance function for serializable class type defaults.
97d7b30 
- Added support for parsing multiple matched default config files #58.
- Fixed pattern in default_config_files not using sort.
- Prepare for release v3.16.0.
@mauvilsa
Copy link
Member

mauvilsa commented Jul 5, 2021

This is now part of release v3.16.0.

@mauvilsa mauvilsa closed this as completed Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mauvilsa @stasbel