feat(sdk): withExecAndTransfer call constructor #3033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ga-reth
force-pushed
the
gv/sdk-execution-call-to-support-middleman
branch
from
762d9a8 to
bddda2b
Compare
ga-reth
changed the title
kevinhalliday
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
ExecutionCallto enable support for execution via middleman contract, without leaking implementation to users (mostly motivated by the fact the rp gist is incorrect right now without this). Ideally, we'd infer this rather than bloating the interface, but onBehalfOf functionality is different across protocols.issue: none